-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for specifying a custom camera app for image questions #659
Conversation
e71f095
to
5469ae6
Compare
5469ae6
to
4471353
Compare
4a54e64
to
3b7d7c8
Compare
5104ec4
to
4f432b1
Compare
4f432b1
to
feb5944
Compare
d2a6827
to
af0764c
Compare
524f2b7
to
522d577
Compare
522d577
to
6cab032
Compare
6cab032
to
a6e2874
Compare
@lindsay-stevens I used |
I recommend using the dev requirements as-is and using a supported Python version. In addition to the readme, the GitHub workflows show how to set up a dev environment from scratch. The union operator for types was added in Python 3.10 (docs) as an alternative to |
Right. It's fixed. |
@grzesiek2010 not sure if you're waiting on me but there are a few comments from the last review to address. Thanks |
ups what exactly? I think I've addressed all of them. I've responded to all your comments with |
@grzesiek2010 I thought you could see the comments because you responded to the one about the Union operator. I have tagged you in the remaining ones. Thanks |
806d23d
to
7dd6b9c
Compare
7dd6b9c
to
23f35ff
Compare
11764ed
to
cbac91c
Compare
Thanks @grzesiek2010 ! @lognaturel I think the PR is ready to merge - do you want this in master or some other branch? |
We’re going to master now! Can’t wait to get all the good stuff there released. 🚀 |
Closes #651
Why is this the best possible solution? Were any other approaches considered?
This is consistent with how we handle other parameters.
What are the regression risks?
This is not a risky change. It's isolated and touches only image questions.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
Yes XLSForm/xlsform.github.io#247
Before submitting this PR, please make sure you have:
tests
nosetests
and verified all tests passblack pyxform tests
to format code